Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdstanr and posterior updates #10

Closed
wants to merge 17 commits into from
Closed

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented Jan 10, 2024

This modifies the cmdstanfit method to use the soon to be merged updated unconstrain_draws method.
Also updates the pareto_smooth function to use latest option are_log_weights so the weights don't need to be exponentiated first.

Addresses #8

@topipa
Copy link
Owner

topipa commented Sep 7, 2024

@n-kall I think the changes in this PR were introduced in #14, and we are now using the simpler form udraws <- x$unconstrain_draws(format = "draws_matrix"). Can this be closed, or is there something I missed?

@n-kall
Copy link
Collaborator Author

n-kall commented Sep 8, 2024

This PR also has updates using the new are_log_weights =TRUE for pareto smoothing, which could be added. I can look again next week, or you can check if this PR can be selectively merged in the meantime

@topipa
Copy link
Owner

topipa commented Sep 8, 2024

Those were also added already. In hindsight it would have been much clearer to merge those changes in separate PRs. I'll try to have smaller and better separated PRs going forward.

I actually tried to pull the changes in this branch into the current main, and there does not seem to be any meaningful changes left (see here), unless I missed something in solving merge conflicts.

@n-kall
Copy link
Collaborator Author

n-kall commented Sep 8, 2024

Great! Yeah I realised that I shouldn't have put these in the same PR. I didn't realise it would be hanging for so long due to delayed posterior release, but we eventually manages to get that on CRAN

@topipa
Copy link
Owner

topipa commented Sep 8, 2024

Yeah the delay complicated things. But good that it's now clear, I will close this one.

@topipa topipa closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants