-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmdstanr and posterior updates #10
Conversation
This PR also has updates using the new |
Those were also added already. In hindsight it would have been much clearer to merge those changes in separate PRs. I'll try to have smaller and better separated PRs going forward. I actually tried to pull the changes in this branch into the current main, and there does not seem to be any meaningful changes left (see here), unless I missed something in solving merge conflicts. |
Great! Yeah I realised that I shouldn't have put these in the same PR. I didn't realise it would be hanging for so long due to delayed posterior release, but we eventually manages to get that on CRAN |
Yeah the delay complicated things. But good that it's now clear, I will close this one. |
This modifies the cmdstanfit method to use the soon to be merged updated
unconstrain_draws
method.Also updates the pareto_smooth function to use latest option
are_log_weights
so the weights don't need to be exponentiated first.Addresses #8